RuneScape:Administrative requests/Archive 7

From the RuneScape Wiki, the wiki for all things RuneScape
Jump to: navigation, search
Archive
This page or section is an archive.
Please do not edit the contents of this page. Direct any additional comments to the current project page or contact an administrator for aid if no talk page exists.

Collapsible maps[edit source]

After seeing a recent attempt to make a decent number of interactive maps hidden behind a collapsed-by-default table fail, I thought it'd be nice to offer a solution to make that sort of thing possible. So, here's the code snippet that would enable this:

$( ".mw-collapsible-toggle" ).on( "click keypress", function() {
    const $this = $( this );
    
    if( $this.hasClass( "mw-collapsible-toggle-expanded" ) ) {
        mw.hook( "wikipage.content" ).fire(
            $( "a.mw-kartographer-map", $this.parents( ".mw-collapsible" ).first() ).parent()
        );
    }
} );

Assuming it's even desired at all, I'm not sure where it would best be placed to serve its purpose. It just needs to be run once after page load, and it seems rather wasteful to create an entire new gadget just for that small bit of code. Perhaps MediaWiki:Gadget-autocollapse.js could be abused? ¯\_(ツ)_/¯

MrDew (talk) 17:41, 9 September 2020 (UTC)

Done - Habblet (talk|c) 16:55, 11 October 2020 (UTC)

Deterministic order of execution for table-related gadgets/plugins[edit source]

I've experienced this problem before, but a recent message in #wiki-rs from another user spurred me to look into the problem that is the order of execution of three gadgets/plugins that deal with tables: the tablesorter jQuery plugin, the autosort gadget, and the lighttables gadget.

With the way the resource loader and/or different browsers behave, this execution order appears to be non-deterministic. This is a problem, because those three things actually have implicit timing dependencies: the autosort gadget can't autosort if the tablesorter plugin hasn't run yet, and the lighttables gadget will happily highlight rows regardless of whether or not the autosort gadget has changed the row orders yet.

The ideal solution would be to use mw.hook() to subscribe to/fire events in each of those three things. Unfortunately, the tablesorter plugin is a core component of MediaWiki, so editing it is more of a PITA that would require getting server techs involved, patching code that could cause merge conflicts with MW upgrades, etc. etc. Instead, I went with a slightly-less-ideal (but still 100% functional) solution where the autosort gadget will use a MutationObserver rather than a hook.

Here are the two changes I'm requesting:

TIA,
MrDew (talk) 16:43, 12 September 2020 (UTC)

Looking good, I've transferred the changes over. Quest.png Gaz Lloyd 7:^]Events!99s 19:21, 16 October 2020 (UTC)

pengLocations[edit source]

Whatever changes have been made to JS in the past week, pengLocations.js no longer runs. --Saftzie (talk) 00:47, 25 March 2020 (UTC)

@Saftzie I'm not seeing anything obvious that fixed this, but nonetheless it appears to now be working on Distractions and Diversions/Locations/Penguin Hide and Seek. Can you confirm or point to somewhere it's not working? cqm talk 22:01, 4 April 2020 (UTC)
It doesn't work for me. There are also no errors in my web console. Whatever has gone wrong, it appears to affect everything that loads as a gadget. --Saftzie (talk) 00:17, 8 April 2020 (UTC)

Fix #2: Electric boogaloo Calcs on article pages double-initing sortable tables[edit source]

MediaWiki:Gadget-calc-core.js's dispResult function is blindly assuming that the only sortable table in the entire DOM will be one that it has created during the course of displaying a calculator's result. For "Calculator:" pages, this is probably always true. For article pages that contain embedded calculators (example: Seren godbow)... this can be not true.

The jquery.tablesorter plugin from MediaWiki is rather dumb. If called multiple times on a given table, it will attach multiple click handlers to that same table. Proposed solution is to modify the calc code so that it only inits the tablesorter plugin on tables that haven't already been processed.

In MediaWiki:Gadget-calc-core.js, change line 795 to be this:

795                 $('table.sortable:not(.jquery-tablesorter)').tablesorter();

FWIW, there's similar code in MediaWiki:Gadget-perkcalc-core.js / MediaWiki:Gadget-perkcalc2-core.js that may or may not cause the same issue if used on other article pages with sortable tables. MrDew (talk) 14:40, 4 June 2020 (UTC)

I wonder if a better fix is to fire the mw content ready hook for the div we load the parsed content into (same as the recent kartographer/switchinfobox fix). cqm talk 15:05, 4 June 2020 (UTC)
As long as the calcs (et al.) are completely wiping the results container and creating new tables each time that hook gets called... that could also work. I say that because even MediaWiki's built-in mediawiki.page.ready resource doesn't do the above safety check of skipping .sortable tables that already have the .jquery-tablesorter class. MrDew (talk) 15:11, 4 June 2020 (UTC)
This change has been made (a while ago) Seers headband 2 chathead.png Elessar2 (talk) 07:45, 3 November 2020 (UTC)

Perk Calculator Rare material order[edit source]

Since the renaming of the Third-age components, it has been in the wrong place on the Calculator:Perks page due it it not having been moved on the MediaWiki:Gadget-perkcalc-core.js.

This needs moving as the perks are in alphabetical order in game and all other perks are in the correct order. Talk pageSevto     18:42, 9 October 2020 (UTC)

Done. Lava hawk.png BlackHawk (Talk)    19:25, 9 October 2020 (UTC)

Portal-link alignment fix[edit source]

The alignment of Achievements#Combat_achievements is all over the place. This can be fixed in MediaWiki:Common.less/portals.less by removing display: inline-flex; from .portal-link and adding

display: flex;
flex-wrap: wrap;
justify-content: center;

to .portal-link-wrapper.  —The preceding unsigned comment was added by CephHunter (talk) on 07:11, 3 November 2020 (UTC).

Has been done! Thank you for making it easy. Seers headband 2 chathead.png Elessar2 (talk) 07:35, 3 November 2020 (UTC)

Corrupted slayer helmet reduced subsequent cost[edit source]

The Corrupted slayer helmet's page does not mention the reduced cost (100 Slayer points) for subsequent upgrades like the Mighty slayer helmet, Strong slayer helmet, and Reinforced slayer helmet pages do. I am unable to amend it as it is a protected page, please could someone with access make the change. GameVsLife (talk) 01:31, 6 November 2020 (UTC)

Hi, I don't think that the page needs to be protected any more so I have removed the protection. I haven't added the information because I'm not 100% sure what you mean to change - but you can go ahead and edit now. Magic logs detail.pngIsobelJTalk page 19:33, 6 November 2020 (UTC)
Thank you, I have now made the change. Helm of Grotesquery chathead.png GameVsLife 00:10, 7 November 2020 (UTC)

F2P melee training lists flesh crawlers' health incorrectly[edit source]

It shows as they'd have 7250 hp but they have 2900 hp  —The preceding unsigned comment was added by Hyvapelaaja (talk) on 10:43 19 November 2020 (UTC).

Thanks, I have updated this. For future issues you may find, feel free to update them yourself :) Lava hawk.png BlackHawk (Talk)    10:49, 19 November 2020 (UTC)

"Block advertisement spam"[edit source]

I've been fixing the links to gem bag (upgraded) so that there are no remaining links to "gem bag upgrade". When I try to fix it on User:Fishncrits7's page, it gives me the following error message:

"Action dissalowed This action has been automatically identified as harmful, and has therefore been disallowed. If you believe your edit was constructive and have received this message in error, please contact an administrator.

The abuse rule which your action matched is: Block advertisement spam."

Can an admin help just simply correct the link on his page? Thanks. RuneMetrics Paul Z Talk bite me HS Contributions 03:22, 8 December 2020 (UTC)

I disabled the filter and made the edit, thanks. ɳex undique 03:28, 8 December 2020 (UTC)

Move request[edit source]

Can an admin move Moorrissey (Pet) to Moorrissey (pet)? The "p" in "pet" needs to be lowercase in order to be in-line with the order pet page names.RuneMetrics Paul Z Talk bite me HS Contributions 04:26, 15 December 2020 (UTC)

Done, thanks. Talk to Kelsey 05:02, 15 December 2020 (UTC)

Administrator[edit source]

How can I become one?  —The preceding unsigned comment was added by Mpadilla013 (talk) on 18:35, 26 December 2020.

Please refer to RS:ADMIN and RS:RFA. Thanks! --Legaia2Pla · ʟ · 18:37, 26 December 2020 (UTC)

Visedit destruction, Job 38:11[edit source]

I've never minced words when it comes to my feelings on the visual editor (especially with it being the default editor). But nothing refreshes my love for it more than when it destroys tables. And by "destroys", I don't just mean "strips some spaces in the wikicode and makes things a lil uglier for the source editors" — I mean it destroys the layout of tables, often gobbling up entire columns and dropping raw HTML tags in place of what was perfectly valid wikicode.

Now, when it happens... hopefully someone is on the ball and notices it promptly. Why? Because it seems to love to do this destruction in an isolated revision immediately following a revision that contains only the changes that the editor intended to make. So, if you're fast enough, it's a simple "undo" operation on that second revision and all is well. But if no one's quick enough and there are subsequent edits, the undo operation can be blocked due to intermediate edits and one must instead take the time to manually un-fuck the wikicode.

Maybe the looming MediaWiki upgrade that's happening Soon™ will fix all of this. Maybe everyone will wake up with shadow dyes in their banks tomorrow. Maybe she's born with it. Maybe it's Maybelline time to create an AbuseFilter rule to stop these shenanigans.

Long-winded intro over, TL;DR of the request is:

  1. Import the following AbuseFilter rule:
    {"row":{"af_id":"1","af_pattern":"article_namespace == 0\r\n\u0026 added_lines rlike '\u003C(li|td|tr|link)|(href|resource)=\"'","af_user":"1","af_user_text":"MrDew","af_timestamp":"20210113183312","af_enabled":"1","af_comments":"","af_public_comments":"Unintended raw HTML or invalid wikicode markup; possible visual editor double submission","af_hidden":"0","af_hit_count":"0","af_throttled":"0","af_deleted":"0","af_actions":"disallow","af_global":"0","af_group":"default"},"actions":{"disallow":["abusefilter-visedit-rule"]}}
  2. Create MediaWiki:Abusefilter-visedit-rule as follows:
    Your submission has been automatically blocked because it appears to contain either certain unwanted raw HTML tags or invalid wikicode markup.
    
    If you are using the Visual Editor, your submission may have been saved but inadvertently triggered this message as well. If this is the case, no action is necessary and you may ignore this message.
    
    Otherwise, if you feel you are receiving this message in error, please [{{fullurl:RuneScape:Administrative requests|action=edit&section=new}} contact an administrator].

I'm unsure how to force the VE to fail in this way, so I'm unable to test this weird double-submission behaviour. However, manually triggering this rule causes a pop-up like this.

- MrDew (talk) 18:43, 13 January 2021 (UTC)

Oppose - This isn’t a forum thread so opposing it may be strange, but ultimately I think this is extremely likely to lose good edits from anons just because we care a lot about VE bullshit that we usually fix in a reasonable amount of time. Blocking edits entirely when it’s not really the user’s fault that VE has been weird (which imo does not happen as often as people complain it does, especially compared to Wikia as our VE version is newer) seems like a really really shitty idea. jayden 08:44, 14 January 2021 (UTC)

"I think this is extremely likely to lose good edits" - I can't wrap my head around how you came to that conclusion... guessing I never will, either. Oh well. Request withdrawn. MrDew (talk) 08:53, 14 January 2021 (UTC)

Voice of Seren broken?[edit source]

So I'm not sure if this is just me but I'm getting an error that says to contact you guys

There was an error loading the Voice of Seren. Please try again later. If this issue persists, please contact an administrator.

It seems to have been down for over an hour now so if it's not just me then I think something probably broke it?

Thanks,

Walk here Chee (skill: 2894)  Choose OptionFollow Chee (skill: 2894) Talk to Chee (skill: 2894) View Equipment Chee (skill: 2894) Req Assist Chee (skill: 2894) Examine Chee (skill: 2894) Cancel 12:36, 26 January 2021 (UTC)

It seems it's not just you, I've got the issue too. I've already ruled out @JagexClock on Twitter as that's still operational, so it must be something on our side. But I'm not personally knowledgable about how this was made, so I've pinged Jayden on Discord. Farming-icon.png Salix of Prifddinas (Talk) Prifddinas lodestone icon.png 12:42, 26 January 2021 (UTC)
@Chee:, Jayden has fixed it. =D Farming-icon.png Salix of Prifddinas (Talk) Prifddinas lodestone icon.png 13:06, 26 January 2021 (UTC)