Forum:GEMH graphs

From the RuneScape Wiki, the wiki for all things RuneScape
Jump to: navigation, search
Forums: Yew Grove > GEMH graphs
Archive
This page or section is an archive.
Please do not edit the contents of this page.
This thread was archived on 3 December 2012 by Joeytje50.
(GEMH image deleted)

Hello everyone! If you've ever needed to look up the price history of an item on the wiki, you've probably been confronted with something similar to what you see to the right.

When they were first made back in 2008 and 2009, they were the probably the best Grand Exchange graphs in existence. However, with no disrespect to Azliq (who deserves some kind of trophy for maintaining these for more than three years), they're just not that great anymore. Other sites (including a couple that we're affiliated with) have started to make graphs that are easy to use, and ours just lie there. They're not interactive, you can't change the scale, and perhaps worst of all, they're only updated once a month.

We can do so much better, for a number of reasons:

  • We have an insane amount of price data, going back at least to the beginning of 2009, and in part to 2008. We have at least 2.4 million different prices (accounting, by the way, for 40% of our total revisons.)
  • In addition to prices, we also have kept historical volume data on the top 100 items going back to last Februrary. I'm unaware of anyone else who keeps this data at all.
  • We are the biggest, most popular RuneScape help site there is (yay ego!). If we change our graphs, people will notice. If they're good, people will use them exclusively.
http://images.wikia.com/runescapeimageshost/images/thumb/f/f7/Charts_example.png/180px-Charts_example.png

With all this in mind, I heroically begged Joey to find a way to make our graphs awesome. We decided to use the Highcharts JavaScript library, and over the last two weeks he and Az have been tweaking the [[MediaWiki:Common.js/GECharts.js|script]] to create charts that are not only better than what we currently have, but the best, period. You can see a picture of it to the right, but that misses the interactive part of it: to get the full experience, go to your common.js and add the following:

importScriptURI('http://code.highcharts.com/stock/highstock.js');
addOnloadHook(function() {
if (typeof Highcharts != 'undefined') {
	importScript('MediaWiki:Common.js/GECharts.js')
}
});

Then go to Exchange:Test/Data and watch the fireworks.

Consequences

Should this thread pass, a few things will happen:

  • Data subpages will be made for every Exchange page, first extracting historical data in the same way as we've done in the past, and then to be updated concurrently with the daily price updates from the Exchange bots. We'll also include volume where applicable.
  • The Highcharts code will be added to the site JavaScript.
  • GEMH and GEMV files will be deleted unless someone has an objection. On infoboxes, they'll be replaced by the small version of the chart (see below), and on Exchange pages they'll be replaced by the full versions. CTI and GEMW graphs will also get the same treatment eventually.
  • We'll probably want to make some kind of sitewide announcement just so people know what's going on. Perhaps we want feeback from the general public too.

Script specifics

Browser support

The script works perfectly on Google Chrome, Firefox and Opera. Safari has not been tested, but it is likely to work there too since it's so similar to Chrome. For Internet Explorer 9, the chart is a lot slower than in the other browsers (especially when clicking on the chart and dragging it horizontally). Other than that, the chart works fine. In Internet Explorer 8, the chart doesn't load until the page has been refreshed several times, and when it does, it's also very slow, and the volume is black, which may look bad. In Internet Explorer 7 and lower, the chart just doesn't show at all. For Internet Explorer 8 and lower, a message shows up recommending them to install IE9, Chrome, FF or Opera.

Layout

The chart's default dimensions are 500px high, and 100% wide. When the chart is put in a floating element, it becomes 500px wide, and when the element it is put in has a size specified, it will get that size (unless the size is smaller than 500px, which will still keep it at 500px). The chart will be embedded on Exchange: info pages. With the current charts being 590px wide, the 500px wide charts should fit on the pages. The chart will also be displayed in infoboxes, where currently the chart images are. There, the chart will be 260px wide and 200px high. Below the chart will be a button to enlarge the chart, which will pop up a screen similar to the Item compare popup, where the chart will be enlarged to 500px high and ~80% wide (~80% of the whole screen, not the page content width). If the 500px high chart would not fit on your screen (when your resolution is too low, you've resized your browser window, etc), the popup box can be scrolled down to see the rest of the chart.

Features

The chart has a form above it where you can modify 2 things about the chart: You can change the amount of days used in the moving average (which is 30 by default). You can also add items to the graph by entering the item name, and remove them again by clicking the link that appears below the form after adding the item. If there are no additional items left in the chart, the chart will revert to the look that includes the averages and volumes. In the popup, you will see a box, which is positioned in the right bottom of the screen, which has the price changes over the past 1, 7, 30, 90 and 180 days, the current price, the item value and the buy limit. It is currently not possible to put 2 charts on the same page. This is being worked on, and should be possible soon.

These graphs are an enormous step forward from our current situation. The script has very few foreseeable risks or issues, and more than likely the charts will become quite popular with our visitors. Drown the competition!

Suggestions

This section is for if you have any suggestions. Because the script can be customised in a lot of ways, almost any realistic suggestion can be done. If you have any suggestion that will make the chart more user-friendly, or if you have any wild ideas that might just improve the chart, please suggest them here. It's a lot harder to change it later than to change it now, so it's best that all suggestions are brought up before it's implemented.

  1. Can you please construct a test page showing the chart in an item infobox? --Henneyj 21:32, October 10, 2012 (UTC)
    You can check the way the chart works in an infobox at User:Joeytje50/Sandbox. It would require a lot of tweaking in the infobox templates to actually show it inside the box, but this is what the chart will look like when it's transcluded into the infobox. JOEYTJE50TALKpull my finger 10:36, October 11, 2012 (UTC)
  2. Colour customisation of lines etc based on a user's preferences?MolMan 21:44, October 10, 2012 (UTC)
    If you put var GEMWChartColors = ['#FF000','#FFFF00','etc...']; on your /common.js or /skin.js page, it will load the list of colors you defined there. So, that example will make the first chart line red, and the second line yellow. If there are more lines than colors you defined, the chart will re-use the color (if you only set 2 colors, the 3rd line will be the same color as the 1st one). JOEYTJE50TALKpull my finger 10:36, October 11, 2012 (UTC)
  3. All time high/lows? MolMan 21:44, October 10, 2012 (UTC)
    This has actually been tried before. A while ago, we had 30-day max and min lines, which looked like this (that's hair's pic I stole from below >:D). Cook and I thought the lines would clog up the interface, especially when the lines went through a lot of the price data. If you think this would be a good thing to have though, I could add it back in. I don't think making it preference-based would be good, since almost nobody will do it then, and it's just better not to have it in that case. JOEYTJE50TALKpull my finger 10:36, October 11, 2012 (UTC)
  4. Adding a datepicker calender. Example here. I don't know if we can import other APIs, but this would be cool if we can get it to work.   az talk   02:50, October 15, 2012 (UTC)

Discussion

Support - as co-nominator (along with Cook) JOEYTJE50TALKpull my finger 20:58, October 10, 2012 (UTC)

Support, conditional to fixing some issues - I see that the issue with the All zoom level is still there. Basically, if I point to certain dates, either the price is gone, or the volume is gone. See [1]; [2]. These pictures were made before this thread was made, so the average line wasn't there. The 30-day average is a nice touch, but for some reason, clicking "30-day average" and "Nature rune" to hide their lines collapses data in 2009. Clicking both, to hide both, collapses even more data. Clicking "Volume" to hide its line collapses data from 2011 instead. Perhaps the dates are badly specified in the chart script.

 a proofreader ▸ 

21:23, October 10, 2012 (UTC)

I've tried looking into the problem with the volume charts, but there doesn't seem to be a good fix. The only fix I was able to think of is changing back to the original system which has a huge blank space above the volume charts, which is not used. The volume chart would zoom out along with the price chart, causing the volume chart's axis to range from 0 to 12.5M, while the volumes were all less than 2M. This huge whitespace also made the chart less detailed (fitting a line within 1/5th of the chart with 4/5th whitespace leaves very few pixels to vary in height in) which just looks bad. The bug with the chart being too high at some points when zooming out too quickly only seems to occur when you zoom out from a short period to 1 year or all data, and it is fixed as soon as you move the chart a bit. I think this bug is minor enough to be ignored, since there is no good fix (as far as I know).
For the bug with hiding the 30-day average and Nature rune lines, I'm not sure if I get what you mean. If you mean the shift in the width of the graph when you hide all lines in one of the 2 axes, that is because there might be more points on the one axis than the other. If that axis no longer exists, the x-axis will adapt to only the remaining chart, not the hidden chart, and that will make it collapse. That's the reason why both charts get less wide when the other axis is hidden. JOEYTJE50TALKpull my finger 11:00, October 11, 2012 (UTC)

Support - I wrote the good part. There are plenty of problems that need to be addressed before we fully implement this proposal (and we should probably just set up a place for people to report them), but there's no doubt that when it's finished, it will be totally worth it. ʞooɔ 21:33, October 10, 2012 (UTC)

Comment and Support - That's on Safari, so it does work on that browser too... it seems Internet Explorer just happens to be the weakest link Wink. Other than this, I think that these graphs are very interesting and would be fun to see on the wiki! Hair 21:40, October 10, 2012 (UTC)

The script you've imported is the old version. You should update the import using the code given above. That will show all kinds of new stuff. JOEYTJE50TALKpull my finger 07:38, October 11, 2012 (UTC)

Support - +2 suggestions which I'm not sure whether or not they're already there (doesn't sound like it). Also yay, no more graph smush smush MolMan 21:44, October 10, 2012 (UTC)

Support - Nice job, guys! This looks so much better than our current system, can't wait to see it released. ɳex undique 22:00, October 10, 2012 (UTC)

Support - Seems better, more interactive like tip.it's charts. I like those! :) — Jr Mime (talk) 22:01, October 10, 2012 (UTC)

Support - Can we close this earlier?! :p. HaidroH rune.pngEagle feather 3.pngCandle (blood red).png 1XqyDNM.png Crystal triskelion fragment 3.pngHazelmere's signet ring.png 05:06, October 11, 2012 (UTC)

Support - The only problem I can see is the recommendation to install Opera. I was unaware of this until recently, but Wikia doesn't support it (Help:Supported browsers). I'd suggest removing it from the list in case it causes other problems that we can't control. cqm 10:44,11/10/2012 (UTC) (UTC)

Support - Yay! Kudos to both Cook and Joey for coming up with the idea. Maybe you guys should add a list of bugs... one minor bug would be the volume axis thingy.   az talk   02:50, October 15, 2012 (UTC)

BUMP - JOEYTJE50TALKpull my finger 15:23, October 21, 2012 (UTC)

Can you add an exploding turtle like the one you've already made to the charts? Ya know, just in case I get bored with knowing that a bronze dagger is 1738 coins and want to have some fun. MolMan 23:38, October 21, 2012 (UTC)
Sure, I'll replace the charts with the turtle automatically in 10 seconds after loading the page. After all, that's why people are REALLY on this wiki :D JOEYTJE50TALKpull my finger 09:11, October 22, 2012 (UTC)

Support - Seriously, they're amazing. A lot better than what we have. Blaze_fire.png12.png 14:01, October 31, 2012 (UTC)

Things to solve:

  1. MAJOR: Multiple charts (small charts) cannot be displayed in one page, like in Grand Exchange Market Watch.
  2. Volume axis is screwed up when zoom level is changed. (Temporary solution is to use zoom level one step at a time. 1M -> 2M -> 3M and so on...)
  3. itemStats box (in popup charts) requires commas, and possibly rounding for high/long prices (i.e. 1M, 1B). Example: Red partyhat
  4. Items with long names make the legend too wide, and thus shrinks the width of the plot area of the chart. Example: Dragon platelegs/skirt ornament kit (or)

Feel free to add other issues... Joeytje50.   az talk   02:03, October 23, 2012 (UTC)

I've fixed the third one. Do you have any suggestions for the 4th one? I can't just leave out a part of the name, can I? The 2nd one is so incredibly difficult to make flawless, or atleast for what I've seen so far, that I'm not going to waste more time trying to fix it. It is a very minor bug, and it can be fixed easily by correcting the range of the chart a bit, so I'm going to leave that one in. The charts are at 99% functionality, and I'm not going to spend hours on the extra 1%. The first point is a tough one, and I'm going to make that one work. It will require a revamp of the whole script though. JOEYTJE50TALKpull my finger 16:26, October 25, 2012 (UTC)
I have no idea how feasible this is, but what about if the title is too long using something like Dragon platelegs/skirt or... and wrap it in span title tags, ie Dragon platelegs/skirt or.... I don't know if you want to make it more appealing to hover over so it isn't missed. cqm 20:11, 31 Oct 2012 (UTC) (UTC)

Support - We shall longer have teh suck of graphs. svco4bY.png3Gf5N2F.png 17:33, October 31, 2012 (UTC)

Support - Cus dey gurd. cqm 20:11, 31 Oct 2012 (UTC) (UTC)

Pre-closure question - Does anything else need to be said here? sssSp7p.pngIjLCqFF.png 03:36, November 12, 2012 (UTC)

That Joey has fixed the issues that were presented in this thread in the script. svco4bY.png3Gf5N2F.png 03:37, November 12, 2012 (UTC)
If the major issue (#1) has been fixed, we can close this... and I can start uploading the data pages. #2 can be ignored (according to Joey), #3 is fixed, #4 is minor since only 113 items have names with 24 chars or more...
Question: Has the GE bots agreed to update the data pages with price updates once they're ready?   az talk   10:18, November 12, 2012 (UTC)
I'd imagine that is a task for Σ, the writer of the bot's code, unless Ty is able to do it himself? cqm 14:16, 12 Nov 2012 (UTC) (UTC)
I've already written the code, assuming they have the exact same format as Exchange:Test/Data. svco4bY.png3Gf5N2F.png 18:17, November 12, 2012 (UTC)
Okay, the bot that updates the data pages is ready then, the script is ready (I'm gonna make it work with multiple charts on 1 page too, but that is not an essential feature), and it it looks like nobody has anything left to say. The only problem now is that the volume charts and the index charts are not being dealt with every GE update by a bot, so maybe the index pages can be done by TyBot too (just getting the number from the index template, and putting it on another line on the data page), and for the volume charts there still needs to be a solution. Other than that, I think these charts are good to go. JOEYTJE50TALKpull my finger 19:49, November 13, 2012 (UTC)

Closed - The script will be installed, and the bots can now run to upload and update the Data pages. Any further questions about the script can be asked on my Talk page. JOEYTJE50TALKpull my finger 20:11, November 14, 2012 (UTC)

Reopening - I think I want to keep this thread open until we have done all the necessary work... like uploading, modifying the templates, adding the script, deleting the old graphs, etc. (I thought we only archived YG threads when the work is completed?)   az talk   16:42, November 15, 2012 (UTC)
If this is going to continue to be re-opened can someone change the protection on it? cqm 17:10, 15 Nov 2012 (UTC) (UTC)
Done.  a proofreader ▸  17:14, November 15, 2012 (UTC)
TyBot is running and updating the /Data pages for the items. svco4bY.png3Gf5N2F.png 01:04, November 16, 2012 (UTC)
I noticed that there are decimals in the unixdate? Could you just use the date, and not include the time?   az talk   04:59, November 16, 2012 (UTC)

Comment - I've finished making multiple charts on 1 page work now. Please try finding as many bugs as you can. You can use the url modifiers to change the graph on pageload, examples being Exchange:Plank/Data#i=Oak plank,Teak plank,Mahogany plank,Limestone brick#z=6#a=50 and User:Joeytje50/Sandbox 2#z=5#a=60. Also feel free to use RS:S to test template usage of the charts if you want. If you've found any bug, please report them (as detailed as possible) here. Thanks. JOEYTJE50TALKpull my finger 21:52, November 19, 2012 (UTC)

Note to self: Check what a brand new data page looks like, with 1 or 2 points of data, and see if it looks acceptable. If not, set a minimum of 10 points or so. JOEYTJE50TALKpull my finger 21:57, November 20, 2012 (UTC)
I used a minimum of 2 points for the earlier graphs, since you can see a line in a graph with 2 points. This should apply for volumes as well, because they are some items with only 1 volume data. We don't need to display the volume for these items.
Also, please use the sitenotice to inform users when we start making changes to the infobox templates, and refer them back to this thread. That way maybe we can get "feeback from the general public" as Cook said...   az talk   03:26, November 21, 2012 (UTC)
Looking at this one-point chart, nothing really breaks when there's only 1 point of data on the chart. It won't be helpful, but it won't break either. I'm going to keep the chart the same as it is, because it can be useful to have the 1-point chart so you can put the chart in the infobox immediately and see the result, instead of causing people to get confused ("huh but I did add the chart, why isn't it showing up? @@@"). Also another note to self: Make the price update script on Exchange: pages work when the /Data page doesn't exist yet, so it creates it and adds the correct stuff. JOEYTJE50TALKpull my finger 11:35, November 21, 2012 (UTC)

Question - Can we enable subpages for the Exchange namespace now?   az talk   09:08, November 22, 2012 (UTC)

Answer - I already Special:Contacted Wikia about this, their reply was "Sorry, but the subpages would run into the same problem as pre-existing namespace pages in that they may no longer be accessible once the namespace sub page is set up.", so this is not possible unless we want to go through a lot of trouble for it. It's not a very big deal though, it's just a little notice at the top with the basepagename on it, which is not that important. JOEYTJE50TALKpull my finger 12:28, November 22, 2012 (UTC)

Adding a checklist for joey and me...   az talk   10:18, November 22, 2012 (UTC)

Checklist

  1. Create Data pages - mostly done, not sure about EoC items
  2. Finalise script - done
  3. Script at common.js - done
  4. Style at common.css - done
  5. Delete GEMH
  6. Delete GEMV
  7. Check/update links to GEMH/GEMV images
  8. Sitenotice
  9. Make changes to following templates:
    1. [[Template:ExcgDefault]]
    2. Template:Infobox Item
    3. Template:Infobox Construction
    4. Template:Infobox Food
    5. Template:Infobox Seed
    6. Template:Infobox Set - not used; not possible since the boxes have GE prices for every item seperate.
    7. Template:Infobox Tree - not used but possible??? --how?
    8. Template:Infobar Summon Scroll - not used but possible??? --This probably won't fit well on the page, but maybe below the current boxes.
    9. Template:Infobar Summon Pouch - not used but possible???
  10. Make a change to the script that makes it possible to have a template where you can put a list of items to merge into one graph on pageload, instead of having to let users do that themselves, for example for item pages like Cake.

Feedback

Please post your feedback below. If something is not working well or broken, if you have suggestions, or you just like the new charts, you can put a message below; your feedback is appreciated. JOEYTJE50TALKpull my finger 15:49, November 22, 2012 (UTC)

It's win. I like when the chart changes and the lines drop. Whenever it does that, I say "SWOOOOOOOOOOOOOOOOOOOOOOOOOSH!" MolMan 20:46, November 22, 2012 (UTC)

here you go. JOEYTJE50TALKpull my finger 20:49, November 22, 2012 (UTC)
RS:UTP; I will swoosh as I please. MolMan 20:50, November 22, 2012 (UTC)
k go edit the function yourself. :c JOEYTJE50TALKpull my finger 20:51, November 22, 2012 (UTC)
It wasn't a suggestion of any sort. I was simply stating that when I use it, I like to make those noises. MolMan 20:53, November 22, 2012 (UTC)

Additional bug - Mini-graphs embedded on pages force a scroll to the top once they have loaded. I may, for example, be loading a diff, and want to see what's below the diff. I'll start scrolling, but then be taken to the top again.

 a proofreader ▸ 

09:35, November 23, 2012 (UTC)

Ah that's a FF bug, I'll have a look at that. JOEYTJE50TALKpull my finger 12:24, November 24, 2012 (UTC)
Fixed. JOEYTJE50TALKpull my finger 18:52, November 25, 2012 (UTC)

Bug - RuneScape:Grand Exchange Market Watch#Market Indices - Enlarging these graphs seem to make it appear blank. Hair 20:02, November 23, 2012 (UTC)

Fixed. JOEYTJE50TALKpull my finger 18:52, November 25, 2012 (UTC)

Suggestion - It would be nice if I could use the scroll wheel on my mouse (scroll up scrolls right, scroll down scrolls left). Everything else looks very nice. Of course this would have to disable the page scrolling in the background :P/bren/tc 16:04, November 24, 2012 (UTC)

That would not be feasible to make. The small charts have an option to zoom by selecting which area to zoom to now though. The buttons to zoom with are now removed (they take up too much space). JOEYTJE50TALKpull my finger 18:52, November 25, 2012 (UTC)

I think "Enlarge chart" should be moved to a more prominent position - under the item name, maybe? --Iiii I I I 03:56, November 23, 2012 (UTC)

Do you mean in the position of the subtitle in the large charts? JOEYTJE50TALKpull my finger 12:24, November 24, 2012 (UTC)
[3] --Iiii I I I 17:17, November 25, 2012 (UTC)
Okay, done. I've also made the escape button close the chart, like you requested in IRC. JOEYTJE50TALKpull my finger 18:52, November 25, 2012 (UTC)

Bug - In Grand Exchange Market Watch: The smallchart for Herb Index is missing. When you click Enlarge, the chart pops up, but the blue navigator chart (right above the scrollbar) is missing.   az talk   08:47, November 27, 2012 (UTC)

Nevermind. It was due to empty data.   az talk   11:57, November 27, 2012 (UTC)

Comments

  • Infobox Tree: The chart for the log perhaps?
  • Infobor Summon Scroll/Pouch: Yeah. Somewhere below the current template...
  • Infobox Set: Could the multiple-item/merge chart be used for the set items?
  • Small chart: Align the legendtitle to the right, since the title looks off center when aligned with the zoom buttons...
  • Title link: I think we should remove the link; not really useful in the Exchange pages (already linked), popups (same article), and small charts (same article).

  az talk   01:56, November 23, 2012 (UTC)

What do you mean with the point about aligning to the right? In small charts there are no legends. For the infobox points: I'll do that some time after the weekend then. JOEYTJE50TALKpull my finger 12:24, November 24, 2012 (UTC)
Title, my bad.   az talk   16:17, November 24, 2012 (UTC)
I think the title looks good. Especially with the enlarge button below it now, it looks fine to me. JOEYTJE50TALKpull my finger 18:52, November 25, 2012 (UTC)
With the zoom buttons gone, its okay now...   az talk   01:30, November 26, 2012 (UTC)

I like how the mini-charts appear on the pages and how they make a popup when you expand them. However:

  • when the zoom level is below a year, the X axis labels sometimes have a year, and sometimes they're just Mar, Jun, Sep and Dec.
  • there's no easy way for a user to expand a chart into a full page or permalink to it with a certain zoom and item comparisons (like on Google Maps).
  • as of this writing, on the expanded chart popup for Christmas cracker, the 180-day change is NaN.
  • charts are not centered correctly on the screen if the resolution is low: imgur link (it also shows the NaN bug).
 a proofreader ▸ 

01:51, November 23, 2012 (UTC)

The zoom level thing is happening without me knowing at all why or how. I'm going to try fixing other things before starting with that (maybe I'll find it while working on other things). I've fixed the center thing, and I'll have a look at the other points. The NaN thing is quite interesting :P JOEYTJE50TALKpull my finger 12:24, November 24, 2012 (UTC)
I fixed the NaN problem and the centering. I am working on a page you can link to for specific changes to the chart on pageload, which will be linked to from the popup chart. I was thinking of a page like a subpage of GEMW, maybe "Grand Exchange Market Watch/Chart" (or someone else can suggest a better idea). JOEYTJE50TALKpull my finger 18:52, November 25, 2012 (UTC)
"Grand Exchange Market Watch/Historical chart".   az talk   01:30, November 26, 2012 (UTC)
Okay, I've made the permanent link, which you can copy by right clicking and copying. What other way could it be put there so copying the url is easier, but the interface won't be some popup box that appears when clicking that link? JOEYTJE50TALKpull my finger 17:56, November 27, 2012 (UTC)

I agree with Cook about the Exchange page not being much relevant anymore, since users now need to visit the page for exclusively updating the price, something the bots are doing at a frequent rate. Also, there are 2 links to the Exchange page - via the infobox and the pop-up chart - which seems redundant. So, some of my small suggestions are:

  • Remove infobox link to Exchange page.
  • Move Exchange ID Number and maybe the RSGE Database link over to the chart, thereby changing "More price info" to simply "More info".
  • If you can, add autofill for item names.
  • Increase form width for manually entering the dates, since digits seem to go beyond.
  • Add space between the "Submit" and "Reset" buttons.
  • Add line-height between the textbox, buttons and the remove form. They currently kinda stick together.

Also, I tried comparing some items and I got a bug where some items didn't display their entries on a date. Sometimes I'd see 2 items, sometimes a single one. [4] Out of the 16 days selected, only 6 of them showed the 3 items together. --Alchez 14:14, November 27, 2012 (UTC)

That last one will probably be fixed when Az uploaded all omitted data points to the charts. I've done the other things. JOEYTJE50TALKpull my finger 21:46, November 27, 2012 (UTC)

Instead of having multiple boxes that say "<blank> does not exist…", can it be a single pop-up that says "these do not exist: <blank> \n <chocolateblank> \n etc.", there's some great danger in that error. MolMan 22:38, November 27, 2012 (UTC)

I've made it that the alerts don't appear when the chart is loading on pageload. Only when the user adds the item himself he gets an alert that the item doesn't exist (when it doesn't). JOEYTJE50TALKpull my finger 12:08, November 28, 2012 (UTC)
  • On the small version, the graph should not link to the page you're already on.
  • Remove everything besides the graph itself on the small version. The actual line on it is only about a third of the total height of the box. Get rid of the scrollbar, the time buttons, give it less padding.
  • I can't hover over the small graph to get a price. Maybe that's intentional, but if it is, have the big version pop up when you click any part of the box. Not just the "Enlarge chart" button.
  • Remove "Look up price info" link on item pages. It's duplicative.
  • Is there *any* way to make the volume and price graphs not scale the same way? I like that we're not cutting off the volume data point, but it's at the expense of putting more white space around the prices.
  • I don't like the way the data "jumps" when you change the zoom level, but meh.
  • For the data gathering, not the graph itself: if there's no volume point for a day, use the volume from the day before so we don't have days with missing volume. It's not perfect but it'll look less weird. Also tighten up the vandalism control: I noticed that this is being included in the graph even though it's clearly wrong. Also the volume on new items doesn't seem to be coming in regularly -- on the nature rune, no new data in a week. What's up with that?

Overall, pretty great. Glad that's up there now. Small charts still need to be better, because if those aren't good then nobody will want to click the big ones. ʞooɔ 04:59, November 23, 2012 (UTC)

  • "Look up price info" links to the Exchange page. There's no other way to access the Exchange page currently.
  • The "jumps" (animation) can be switched off, but some like that feature, and I think its funny...
  • The missing volume is being plotted, but not shown in the legend. So Joey, we need to fill in the gaps with earlier data. Is this possible?
  • Vandalism cannot be prevented from appearing in the graphs since it is a live graph. That's the disadvantage. *Earlier static graphs were vandalism-free*
  • Currently no bots are updating the volume data. Joey is working on a script. I can try to update it once a week, but it would better if some other bot updates the volume data, once a day.
  az talk   08:57, November 23, 2012 (UTC)
  • Why does the Exchange page need to be user-facing? There's nothing on there now that people need to see.
  • I don't see how anyone could like the jumping. It glitches out and temporarily goes above the height of the graph. Are we talking about different things?
  • The problem with vandalism is the old data, not the new data, which is almost entirely machine-run. Can you use whatever you did to make the static graphs, on the old Data pages? How exactly did you do it anyway? edit It occurs to me that the static graphs were not actually vandalism-free -- the nature rune graph had the same problem I mentioned in that diff.
  • I agree.
ʞooɔ 09:33, November 23, 2012 (UTC)
Ask mol about the animation for fixing the zoom (first comment in the #Feedback). He likes the "woosh". For the vandalism, the bot may indeed have recorded 1 or 2 vandalism edits too. Just fix them if you see them (ctrl+f for the price that's incorrect, and remove the line, or change it to the correct price). JOEYTJE50TALKpull my finger 12:24, November 24, 2012 (UTC)
The filter on prices needs to be tightened, I can't just look for wrong prices and fix them. Also the zoom thing looks absolutely terrible for me and I don't see how anyone could like it...possible that I'm seeing it differently. A couple new problems are that the graph takes an incredibly long time to load for the first time, and the data is showing up on Google. ʞooɔ 13:12, November 24, 2012 (UTC)
Reset...
Exchange pages needs to be linked at least once, IMO. Besides, why do we have a update button and all those RS website links in the Exchange page if we don't want users there? I know bots do all the work, but we still allow users to update, right?
The "vandalised price" was not considered vandalism since no one actually reverted the edit during the day. To detect vandalism, I use a formula. If the price difference is within 1.25, its not considered vandalism. (295/245 = 1.2; 1.2 < 1.25; not considered vandalism).
The more data in the Data page, the longer it takes to load. I think the Data subpage should only be updated if there's a change in price. (A line is still a line if there 2, 3, or 10 points). But the drawback is that there will be gaps in the tooltip when you hover, as Cook noticed. Joey, you want me to update the Data subpages to fill in the missing/ignored data, or can you do it with the script?   az talk   16:17, November 24, 2012 (UTC)
We don't really need the update button anymore. Bots take care of all of it fairly timely. We used to need to link to it because that's where people could find more information about the item, but now that's all in the graph popup.
Could you make the vandalism filter more sensitive? How many times will the price have changed by 25% and it won't be vandalism? It seems like something closer to 10% per day, taking into account very low numbers (1 to 2 changes by 100%) would be more effective. ʞooɔ 08:11, November 25, 2012 (UTC)
I think it would be good to have those additional points filled in. I've noticed that the chart makes the points get closer to each other than they should be if there are no points between them (compare the oldest parts of Exchange:Christmas cracker/Data#z=6 and Exchange:Christmas cracker/Data#z=6#i=Blue_partyhat). So, filling in all the points there are would be better. Also, the update button is for people who want the price to be updated before the bot gets to it. Also, non-script edits are flagged in the abuselog, so vandalism is easy to find. JOEYTJE50TALKpull my finger 13:30, November 25, 2012 (UTC)
I think it would be good to have those additional points filled in. How? You want me to "hardcode" it into the Data subpages, or are you going to fill it in using the script? In terms of loading, which option would be better?   az talk   01:30, November 26, 2012 (UTC)
I think hardcoding it would be best, because then the script won't have to generate as much data itself, which would probably speed it up. Downloading the data won't make it much slower either, since it's just a few bytes, and making the script generate the data itself will still let it render the same amount of data. Hardcoding is the best option here. JOEYTJE50TALKpull my finger 08:42, November 26, 2012 (UTC)
@Cook: Okay, I've implemented all of your suggestions I found useful. I've not made clicking the chart pop it up, since I've already made the zoom function work by dragging on it. Having both would be impossible, and it's good to have atleast one way to zoom with it. I still can't think of a good way to show which item is which line on pages like Cape though.
The volume chart is seperate as much as it can from the price chart. It can't be seperated more. JOEYTJE50TALKpull my finger 21:51, November 27, 2012 (UTC)

Comment - I've created a script that can get a list of all volumes currently on http://services.runescape.com/m=itemdb_rs/top100.ws. Just type importScript('User:Joeytje50/GEVolumes.js'); in your console (press ctrl+shift+J, or F12 and go to the console tab. Requires Firebug extension for Firefox users). It will load for a while (be patient :P) and then it will show a message with the object with all data in it. Could I get a list of item IDs, with their Exchange page names, so that I could get the script to update the prices?
What another way to handle this is that the GE bot could get a command in IRC, where a permitted user can give the bot a list of volumes. I would change the script to show the item list in a format the bot can understand, and an user could copypaste that to the bot like "~vols (list of data)". Then the bot will go through all the pages going by their IDs after updating their prices. JOEYTJE50TALKpull my finger 21:38, November 28, 2012 (UTC)

[[User:AmauriceBot/GE_Items]].   az talk   23:42, November 28, 2012 (UTC)
Ah, I could probably add that to the script. But, if Ty could make his bot work with the ~vols command, or maybe with a subpage on the wiki where the data can be submitted to every GE update by running the script, which tybot will then get data from, that would probably work better. Otherwise, I'd have to switch to my bot account every GE update just to update those prices. Just submitting to that subpage, or using a ~vols command in IRC (until a permanent solution is found using a python script in Tybot) seems easiest for now. JOEYTJE50TALKpull my finger 10:55, November 29, 2012 (UTC)

Closed - No discussion/feedback for 5 days. I think this is done. Everything has been implemented, and if anyone finds any further bugs, they can be reported on my talk page. Any further minor changes can be done without needing further discussion or consensus, so I think this thread has served its purpose. JOEYTJE50TALKpull my finger 08:52, December 3, 2012 (UTC)