Forum:Drops submissions script

From the RuneScape Wiki, the wiki for all things RuneScape
Jump to: navigation, search
Forums: Yew Grove > Drops submissions script
This page or section is an archive.
Please do not edit the contents of this page.
This thread was archived on 17 February 2012 by Karlis.

Click here to see the scripts

Proposal 1[edit source]

I've created a script that makes it easier for users to add drops to monster pages. Currently, quite some users, especially newer users and unregistered users, are having trouble adding drops to monster pages, adding the drop as plain words on the article, replacing it with the closing |} of the table or submitting rare drop table drops. Because of this, I've made the script recognise rdt drops, and alert the user that these are already listed below on the page. Also, it makes it easier for the user to use the correct format for adding drops, as they only have to enter the name of the item, the quantity and the rarity, and optionally uncheck a checkbox for if it's sold on the GE or not and then (also optionally) enter a filename for an image. Adding multiple monster drops is possible by just clicking to add monster drops again.

Proposal 2[edit source]

I've also created a script along with that to submit to charm logs the same way as the GEMW submit script. Like helm asked on Q's talk more than 1 year and 3 months ago, and the script I made does exactly what helm asked there. It also blocks submissions of less than 50 kills (may change), and adds a - (Possible vandalism/spam) notice at the end of the summary, but only when the submission has a value that differs more than 15% from the current data. I added the "spam" part to trigger the CVN bots, so people watching the IRC CVN channel will be able to spot the edit more easily for review. The tag is within /* and */ to mark it grey (a section link), so it is clear it's not part of the actual summary.

The script also turns the links to the submission pages into a link to open the box, so you can submit via the monster page itself too. I've added some extra code to make it support the Waterfiend page too, and if there are any other monsters that have multiple charm submit pages in the future, you can notice me on my talk page and I'll make the change to the script so it supports those too.

Necessary changes[edit source]

To add either of those two proposals, we'd need to have importScript('User:Joeytje50/Dropadd.js') to [[MWI:C.JS]], and if proposal 2 passes, we'd also need .autocomment a[href="#.28possible_vandalism.2Fspam.29"] in MWI:C.CSS to hide the links to the "section" of the possible vandalism tag.
If anyone has suggestions for changing notices that are shown when people are blocked from editing (you can find the notices as the things alert('here') in the script. (If either of the proposals doesn't pass I'll edit the script to remove that part).

Discussion[edit source]

Support both - As nominator JOEYTJE50TALKpull my finger 17:36, February 10, 2012 (UTC)

Support both - Let's also have a moment of silence for the big Q. We miss you! Frown --LiquidTalk 18:13, February 10, 2012 (UTC)

Support Both - Unless I'm missing something, these both looks like great scripts! By the way, what ever happened to Q? ɳex undique 19:40, February 10, 2012 (UTC)

He disappeared at the end of March last year and never came back. Frown *observes moment of silence* --LiquidTalk 21:23, February 10, 2012 (UTC)

Comment - I definitely support the concept, as I've seen countless IPs try and add drops quite unsuccessfully, and RDT drops make up the majority of those. However, when I tried to test your script, I did not notice any changes (just testing the first proposal). I simply imported the script into my personal javascript and took a look at a monster's page, as well as trying to edit the drops section, in both visual and source mode. How is this script supposed to be working? On a somewhat unrelated side note, I'd bet there'd be less issues if we didn't have this crappy visual editor, which causes as many problems as it's supposed to fix. Plain text works for Wikipedia. Hofmic Talk 20:38, February 10, 2012 (UTC)

I think the problem with the script not loading is either your or wikia's cache. Just force refresh your cache (or using browser settings) and try again. JOEYTJE50TALKpull my finger 15:41, February 11, 2012 (UTC)

Support Both - Sounds good! Hair 00:48, February 11, 2012 (UTC)

Support both - would definitely help Small recharge gem.png AnselaJonla Slayer-icon.png 00:49, February 11, 2012 (UTC)

Support both - Just... wow... HaidroH rune.pngEagle feather 3.pngCandle (blood red).png 1XqyDNM.png Crystal triskelion fragment 3.pngHazelmere's signet ring.png 01:48, February 11, 2012 (UTC)

Support both - Please. This would benefit everyone. sssSp7p.pngIjLCqFF.png 15:31, February 11, 2012 (UTC)

Comment - As requested by suppa, I made the script only stop RDT edits when the amount of drops is equal to the current RDT template. This means that drops that differ one from the set amounts will not be matched. I'd like to know if you think I should tag possible RDT additions (ones that do match item, but not amount) with - (Possible incorrect RDT submission), or just leave it to the antivandals to check it for themselves. JOEYTJE50TALKpull my finger 17:32, February 11, 2012 (UTC)

Strong support - Would it be possible to get the script to work with {{ItemDropsTableHead}} and {{ItemDropsLine}} as well? Because that would be awesome. Lol Matt (t) 22:42, February 11, 2012 (UTC)

Support both - Per above. Smithing (talk | contribs) 22:48, February 11, 2012 (UTC)

Support - My only concern is about the RDT thing. I may have misread but by the looks of it it will stop any attempts to add drops that already exist on the RDT, even on monster pages without access to the RDT. Other than that it looks like a good idea all round What I've done Ciphrius Kane Talk 22:56, February 11, 2012 (UTC)

In the first version it did indeed do that, but I changed it so it won't block pages that don't have the RDT on it yet (if ($('.rdtable').length) {) JOEYTJE50TALKpull my finger 11:42, February 12, 2012 (UTC)

Support' - Brilliant. User_talk:Fswe1 Fswe1 Brassica Prime symbol.png 07:21, February 12, 2012 (UTC)

Comment - I've tried the script, which works, but when I press to submit the edit, it says "Submitting edit..." but doesn't save the edit. What I was trying to work out was if rdt drops can be added to monsters, which don't have access to the rdt. So what happens in that case? And what's causing it to not save? as it might happen to some ips. Hunter cape (t).png Sentra246Blue hallowe'en mask.png 09:33, February 12, 2012 (UTC)

I've tested it, and it should just work now. I've fixed a bug that was still in the script, so if you'd try again now it should work. To answer your questions: It just lets the edits through in that case, and an undefined variable caused it not to submit (which I fixed now). JOEYTJE50TALKpull my finger 12:06, February 12, 2012 (UTC)
Support, looks good. Hunter cape (t).png Sentra246Blue hallowe'en mask.png 08:08, February 13, 2012 (UTC)

Support both - That would make it many times easier to submit drop logs Prayer-icon.pngTyiloTalkQuest.png 12:45, February 15, 2012 (UTC)

Request closure or bump - looks like unanimous support from here, and there has been only one comment the last 4 days, but if anyone still wants to comment on it, this is also a bump. JOEYTJE50TALKpull my finger 12:33, February 17, 2012 (UTC)

Closed - With unanimous support, these will be implemented. Karlis (talk) (contribs) 17:26, February 17, 2012 (UTC)