Forum:Comparison

From the RuneScape Wiki, the wiki for all things RuneScape
Jump to: navigation, search
Forums: Yew Grove > Comparison
Archive
This page or section is an archive.
Please do not edit the contents of this page.
This thread was archived on 6 September 2009 by Calebchiam.

Today, while trying to decide on which barrows pieces I should use, I though, it could be a lot easier, if we had something that would compare the stat boxes of too items. Even if it where to just show a page where the bonuses boxes are side by side. Maybe we could add a new row to the infobox and it would say: "Compare to:" and there would be space for text. So, for example if I wanted to compare dragon boots and bandos boots, a page would come up with the bonuses beside each other. This would make choosing armor and weapons so much easier.

 Magic longbow.pngCurrently at 86мϊţ¢Ħ Fletching

Discussion

I agree that would be helpful. I'm not sure how putting it in the Infobox would work out though. Zaros tally.PNGBladeQuick chat button.png# 03:21, 11 July 2009 (UTC)

Comment - Something like we have on Shield Article? Now that's a throwing weapon!Doucher4000******r4000I'll eat you! 03:24, 11 July 2009 (UTC)

Support if doable - Sounds like a fantastic idea, comparing two similar items in two different tabs or windows is a pain in the ass. I wonder if some of the programmers on here could whip something up, that is if they are not all working on bots SmileCap and goggles.pngTEbuddy 05:28, 11 July 2009 (UTC)

Support - Per Tebuddy, sounds perfect but is it possible? Runecrafting.gif Mo 55 55 Talk|Sign 06:52, 11 July 2009 (UTC)

Support - *Looks up from code*Lol, I'm not sure how feasible it is though, but maybe we can find a solution. - TehKittyCatTalk Wikian-Book 08:12, 11 July 2009 (UTC)

Support - This would be great as long as its even possible lol Guthix's Book of Balance.png Death1samus Talk Contribs Green hallowe'en mask.png 23:09, 11 July 2009 (UTC)


Comment I hate to burst the bubble, but the only way of doing this currently would be to create a comparison page for each thing you wanna compare. At somepoint over the summer I intend to look into ways of doing calcs (or anything with a user input) using parser functions, but its a way off. --Serenity1137 09:29, 11 July 2009 (UTC)

Comment - It would be awesome if we could make it work, but there's not exactly many ways to do it. We could completely redo every equipable item's page, similar to Exchange: pages (i.e. using something like Template:ExchangeItem for 'storing' the data), but I'm not sure how pratical that would be, and adding it would be quite hard to do with a bot (I think). Another possible method would be to put some code into the bonuses infobox code on each page to allow it to be used in a template (kinda vague I know, I'll have a test now; it'll use <onlyinclude> I think). Just my ideas... Quest.png Gaz Lloyd 7:^]Events!99s 16:04, 11 July 2009 (UTC)

Comment I thought up two ideas.

  • Make image files of the bonuses boxes and then when compared, we would just have to put two images side by side.
  • A bot that would just retrive the bounses coding and place them on a page beside each other.  Magic longbow.pngCurrently at 86мϊţ¢Ħ Fletching
Thats not practical. The first one would take too much work, and the second one is impossible. I have an idea, though, that we have a bot add templates with stat tables for the items, then have a page where you have a template where you enter the two item names, press preview, then the stats for the two items would be displayed next to each other. Then on the stats template. just add a small link to the comparison page like "Click here to compare this item's stats". I've made an example:

We have this template:


{{{1}}} {{{2}}}
{{{{{1}}}}} {{{{{2}}}}}

Now, I've added created stat table templates for Bandos and Dragon boots (Template:Bandos boots and Template:Dragon boots). Now, to compare the stats, we simply type in:

{{Compare|Dragon boots|Bandos boots}}

And the result is:

{{Compare|Bandos boots|Dragon boots}}.

Very simply this can be done. I've done the template stuff, we can make this work by just having a bot add the pages with the stat items, which shouldnt be too hard. --— Enigma 19:06, 11 July 2009 (UTC)

Enigma, that was exactly my second point : /  Magic longbow.pngCurrently at 86мϊţ¢Ħ Fletching
Oh, yes, I misread it >.> zthought you said that whenever someone presses preview a bot woulf take the coding and put it on the page next to each other. Well, at least I explained a method on how to... --— Enigma 19:33, 11 July 2009 (UTC)

Question - What would the bot do? It would add comparisons... But how would it know what to compare with what? And if we would compare Dragon boots to Bandos boots, why wouldn't we also include Bronze boots? I suggest we put this on a page in the 'Runescape:' namespace, just like the Sandbox, and users can put their items there, and after some time, someone undoes it. Ancient talisman.png Oil4 Talk 19:37, 11 July 2009 (UTC)

If you took the time to carefully read the whole thing you'd know the bot would only create pages with the stat boxes for the items. Also, it would be like a calculator, you'd avoid someone ediing the page. --— Enigma 19:44, 11 July 2009 (UTC)
What? I don't understand. Ancient talisman.png Oil4 Talk 20:13, 11 July 2009 (UTC)
Ok, we have some page like RuneScape:Comparison or whatever that has Template:Compare on it. We have a bot that creates pages for items with the stat boxes, like [[Template:Dragon boots]]. On RuneScape:Comparison in the template you type in the name of the items you want to compare (Like {{Compare|Dragon boots|Bandos boots}}) and press preview. It displays the stat boxes from the pages side by side so you can compare them easier. Do you understand now? --— Enigma 21:07, 11 July 2009 (UTC)
So its its own page with essentially two tables for the compared item. And all the bot does is create those tables by themselves and then fetch them when called upon for a comparison. I like it. Cap and goggles.pngTEbuddy 21:21, 11 July 2009 (UTC)

Support - Why not? Since I assume that this can be done, it would be very useful for anyone wishing to compare the stats of two different items.  Tien  21:22, 11 July 2009 (UTC)

Comment - Okay, I've had a bash at it.

  • So I didn't mess with any mainspace stuff (yet), I put the altered code of the Abyssal whip's and the Barrelchest anchor's infoboxes here and here, respectively.
  • I put the code for generating a comparison table here.
  • Putting {{User:Gaz Lloyd/Sandbox 3|User talk:Gaz Lloyd/Sandbox|User talk:Gaz Lloyd/Sandbox 3}} on a page (eventually I'd like it to be {{Compare bonuses|Item1|Item2}} or something) generates the following table to compare the bonuses of the whip and the anchor:

(Note: the top row and the table name (the bit that says "Comparing x and y") is huge due to the large pagenames of my sandboxes where I saved the data.)

The main problem I see is actually adding the altered code the the mainspace; it could be done by bot, but any small change to it could stop it working in comparisons, and I'm not sure if we could add it to the infobox template... but hey, its almost there. Quest.png Gaz Lloyd 7:^]Events!99s 21:45, 11 July 2009 (UTC)

Comment - How about this?. It fetches the contents of the {{infobox bonus}} template, no modifications needed. Also, if the {{infobox bonus}} template is changed, this tool will reflect the changes automatically. --Quarenon  Talk 22:34, 11 July 2009 (UTC)

Works better and is easier to use than mine, good job. Is there any way you could show the bonuses in rows/columns for a more direct comparison? Quest.png Gaz Lloyd 7:^]Events!99s 23:02, 11 July 2009 (UTC)
Comment - Definitely possible, it'll just take some extra effort to parse out the template instead of just displaying the default HTML. I can work on it later if this solution works out for everyone. --Quarenon  Talk 23:38, 11 July 2009 (UTC)

Comment Quarenon! Thats perfect! Its great, I hink its read y for action already.  Magic longbow.pngCurrently at 86мϊţ¢Ħ Fletching

""Question"" How and when will this be put into action?

 Magic longbow.pngCurrently at 86мϊţ¢Ħ Fletching

Comment - I've made some changes per Gaz's suggestion and tweaked it to run faster by caching data when possible. This should be ready to roll now, do we want to add an infobox row with it? The URL to use would be: http://rstools.ath.cx/compare_items.php?items[]=itemname --Quarenon  Talk 03:15, 15 July 2009 (UTC)

Looks pretty neat! Andrew talk 05:32, 15 July 2009 (UTC)
Thanks. --Quarenon  Talk 06:51, 16 July 2009 (UTC)

Support - I thought I should formally support Quarenon's solution; I also support adding a row to Infobox Bonuses with a compare link. Quest.png Gaz Lloyd 7:^]Events!99s 23:03, 18 July 2009 (UTC)

Suport and Question - Support because it would be useful. But I am missing why a bot would be needed. If the stats were all in templates, then they would opperate like userboxes, unless I completly missed something where its actualy bots running around making all the templates work. Or is the bot just to make the templates? I am under the immpression that teh server handles the display of templates. Clarrify here please, or if its something obvious that everyone else gets, my talk page works too. RandoxTalk 01:00, 19 July 2009 (UTC)

Comment - The bot idea was tossed around because item bonus data is not handled in a way that makes it easy to embed an item's bonuses into any page. The bot would have taken the bonus data and put it into a separate page so that we could transclude it, in a similar fashion to the Exchange pages. My proposal does not require bot edits because it pulls the data straight from the item's page. --Quarenon  Talk 01:43, 19 July 2009 (UTC)
Comment - Oh ok. Makes enough sense to me, thanks for clearing that up. RandoxTalk 14:11, 19 July 2009 (UTC)

Support - If this isn't passed just make a script. You can always do that. ShinyUnown T | C | E 15:03, 19 July 2009 (UTC)

Comment - True, although this wouldn't work for the majority of people who are either IPs or don't install scripts. --Quarenon  Talk 23:46, 21 July 2009 (UTC)
Comment - Any estimate on when this will be done Gaz?

 Magic longbow.pngCurrently at 86мϊţ¢Ħ Fletching

Support - Also this should help you out until its done Lol kitty.pngPsycho Robot talkSilver bar.png 22:08, 20 July 2009 (UTC)

Comment - I have added the link to the tool after seeing no opposition. Feel free to post bugs/issues here; I've made a few minor aesthetic changes to it. --Quarenon  Talk 11:12, 23 July 2009 (UTC)

Looks pretty good. However, I have a problem - it does not work for Dragon gauntlets and a Dragonfire shield. I'd guess at the multiple infoboxes, since they have different bonuses in different situations (the other FoG gauntlets should have two infoboxes, also). Any way you could get around this? Quest.png Gaz Lloyd 7:^]Events!99s 11:26, 23 July 2009 (UTC)
Good point, although those do pose a problem because there is nothing in the templates themselves saying which one is charged and which one is uncharged (or whatever the case may be), so the compare table would be labelled ambiguously. The good news is that I just added a nifty suggest-as-you-type feature which helps you find the items you want to compare something with. --Quarenon  Talk 19:53, 23 July 2009 (UTC)
Maybe the bonus template just needs to be changed to include a title. The title could be hidden and could be FullPageName by default, but could be changed in cases like the dragonfire shield and the gauntlets. kitty.pngPsycho Robot talkSilver bar.png 20:38, 23 July 2009 (UTC)

Concern

Comment/Concern - I haven't been following this discussion, and I only noticed this after the changes to the Bonuses template. I'm rather uncomfortable with the link to a site located outside of this wiki. I don't know why, but I'm kinda suspicious of scripts located outside this wiki.

Try talking to the Wikia staff to see if we can host PHP scripts here. If not, figure out a way to do with whatever tools we have in this wiki. (This goes for the Hiscores update bot script, which uses an external script hosted in that site.) And, if I'm not mistaken, the owner of the site can gain access to the IP addresses of logged-in users, and even "steal" cookies. OMG!   az talk   06:09, 24 July 2009 (UTC)

Oh dear god, not IP addresses and cookies! I dont trust that Quarenon guy either, its not like hes an active and trustworthy person. Cap and goggles.pngTEbuddy 06:32, 24 July 2009 (UTC)
Comment - I also don't like the idea of having users need to use external sites for this, but I don't think Quarenon would do anything. - TehKittyCatTalk Wikian-Book 12:52, 24 July 2009 (UTC)
I always knew that Quarenon was up to no good! kitty.pngPsycho Robot talkSilver bar.png 17:24, 24 July 2009 (UTC)
Why do you people take Quarenon as an untrustworthy user? He has rollback, and has made many working scripts. Seriously. ShinyUnown T | C | E 18:00, 24 July 2009 (UTC)
It was sarcasm.....Cap and goggles.pngTEbuddy 21:25, 24 July 2009 (UTC)
I'm assuming good faith on your concerns of Quarenon. Not exactly like every other site can't do the same thing; its a necessary evil. Although if we could get the script/bot/whatever-you-want-to-call-it to work directly from the wiki that would be great. Quest.png Gaz Lloyd 7:^]Events!99s 19:22, 24 July 2009 (UTC)
I agree, assume good faith. I checked out what I could see and it seems fine. In fact it is most likely just a form that retrieves the infobox data and uses jquery for the JavaScript. I recommend the script be converted to a MediaWiki extension to solve these concerns. All we need is the extension to be created, have group approval of it and then we request Wikia install it. The Wikia tech team will check it out and if it is fine they will install it. I recommend we use Special:ItemCompare as the special page for it. - TehKittyCatTalk Wikian-Book 20:16, 24 July 2009 (UTC)
Support - Who could think of a better solution? ShinyUnown T | C | E 20:43, 24 July 2009 (UTC)
I asked [[wikia:User:Uberfuzzy|Uberfuzzy]] if we can do anything. ShinyUnown T | C | E 21:07, 24 July 2009 (UTC)
I already asked in irc before I posted about it Lol and that is what I got my information on the process from. - TehKittyCatTalk Wikian-Book 21:24, 24 July 2009 (UTC)
Oops! Blush ShinyUnown T | C | E 21:27, 24 July 2009 (UTC)

Commentation from outside

A user came into IRC and asked me some stuff about this topic, he hasn't posted anything up here since then so I thought I'd make notes here for the community.

Firstly, to introduce myself I'm Daniel Friesen (aka: Dantman, Nadir Seen Fire). I'm professional programmer, guru in JavaScript and jQuery, and a former MediaWiki developer (some of the code that does stuff on the wiki has bits written by me in it; for example I'm the one that added diffs to rollback pages).

The user asked me a bit about security first. He mentioned the comparison page, and also the highscore updating script which lead to a discussion on what could be used.

To clarify, unless the JavaScript code is manually looking at the user's session cookie and sending it to an external script, that external script doesn't have access to cookies. And while the script does know about IP addresses, unless there is some user specific information being sent with the request you can't really use that info to associate IP addresses with users.

That being said, it does mean that the wiki would be dependent on an external service which is far less reliable than Wikia and could go down, or even permanently die at any point in time. Generally I don't see any wiki doing things like that for anything but pagecounters from actual pagecounter sites. At the very least things like that only happen with code that has been released so everyone can see it.

Firstly to get that highscores thing out of the way. For browser-security reasons JavaScript can't access that highscore information directly, however there is no reason why a bot can't collect highscore information and update it here. Looking over Jagex there isn't anything restricting the sane use of a bot (long as it's sanely throttled to not hit them that much). I have a fork of pywikipediabot meant for use on Wikia (see: [[w:c:dev:List of Bot frameworks]]), if anyone wrote such a bot they're free to add it into the repo. That being said, the user mentioned the [[mw:Extension:External Data|External Data extension]] which theoretically could allow the highscore pages to work without needing any sort of manual or automatic updating.

Now for the items and comparison. I don't see how that feature can't be written in pure JavaScript. MediaWiki's api is extremely powerful, and JS is to.

Something that deserves some consideration is [[mw:Extension:Semantic MediaWiki|Semantic MediaWiki]]. With a bit of tweaks to templates SMW could quite quickly start outputting annotations onto item pages for all the information you have in those stat boxes. Not only does that means that #ask queries could be used to automatically generate list pages out of that data, and Semantic Drilldown can be used to filter down through lists of items and find stuff, but ask has a json format for it, using a combination of JavaScript, XHR, and an ask query with json format something could be written on wiki that creates a comparison of items without contacting any external services.

For some examples and reference on Semantic MediaWiki: http://semantic-mediawiki.org has the user guide, see the bottom of [[w:c:yugioh:Dark Magician]] for an example of data annotated to a page from templates (ignore the size of the factbox, factbox can be disabled by config, it's replaced by something better in later versions, and I've been considering writing some jQuery to add show/hide to the factbox), and see [[w:c:souleater:Special:BrowseData/Abilities]] and [[w:c:naruto:Special:BrowseData/Jutsu]] for examples on Semantic Drilldown, and [[w:c:yugioh:List of "Ally of Justice" monsters]] for a simple example of a list purely generated using annotations to pages.

~ NOTASTAFF Dantman(Local Talk ⁝ [[w:c:animanga:User talk:Dantman|Animanga Talk]]) 21:45, 24 July 2009 (UTC)
Comment - In response to the hiscores script and security: yes, I agree that injecting an external script like this can be a way to run malicious code from the context of the originating page (Wikia). A user has already commented on this and in response I offered this PHP script so you can use your own external script if you have the resources and do not trust the response from my server. The exact method being used for data transfer is akin to JSONP (more info here and here). I used this method and not XHR because XHR has not traditionally supported cross-domain requests until very recently (It's in Firefox 3.5 and IE8, not sure about other browsers). It also requires that the source data page return a specific header (Access-Control-Allow-Origin); Jagex currently doesn't support the header. Another server could be used to proxy the data to insert the header, and at least that would allow the data to transferred in a format that couldn't include arbitrary code. There is another alternative that I recently found which is CSSHttpRequest, but I'm not sure if it would work well or not.
The security issue doesn't apply to the comparison page. It does in fact use JSONP to perform it's auto-complete feature, but the other way around: an API call is made via an external script injection from RuneScape Wiki into the compare page, and MediaWiki could inject code into the comparison page; I trust it not to do that, though Smile
In response to using an automatic-based update: We already discussed it, and Jagex disallows it. I tried to contact Jagex about this since I find that the actual wording may not reflect what they really meant by that rule, but I have not had much luck in getting a definite response.
Extension:External Data looks like an excellent way to do this if we can get it installed and everyone approves of it. From the looks of it, the data would be kept fairly well up-to-date and would be refreshed any time the parser re-renders the page.
As far as alternatives to the comparison page, I agree that a solution that uses the wiki itself might be more desirable for most people. There wouldn't be as much delay in actually retrieving the data, you are still navigating in the wiki, and might even be able to do fancy parser stuff with the data. I'm not sure if going with a pure JavaScript solution is a great idea though, just because there's not many good options for a graceful fallback. The current compare tool also does rely on JavaScript but only to the extent that an item needs to be updated in the tool's local item cache, and I want to try to fix this eventually. One of the original proposals was to make a bot that would first move bonus data onto a separate page so it can be transcluded easily into a comparison page. I decided to come up with the current solution because a) I thought a bot would have involved more work and b) it's not as convenient to compare any items you want if you'd have to constantly change template parameters and re-parse a page using Preview, like we do now with our various parser-function based calculators. I think having a Special page for this would be a more accessible way to do it, and I could definitely help out with that.
I think the Semantic MediaWiki idea is interesting although I haven't had the chance to get any experience with it. From what I've seen it can produce some nice reports on the vast majority of data that goes into an infobox, so this could do much more than just making item comparisons. I don't know how much work it takes to get something like that set up, though. --Quarenon  Talk 00:57, 25 July 2009 (UTC)
Setting up SMW is just a quick config toggle from the staff. It might need one or two button pokes to enable the database and wait for data to be updated at the start. For annotations, simple data like this work beautifully. Minor modifications to the Infobox Bonuses template and all of a sudden all the pages using it will be annotated with that item data.
As for the JavaScript. Rather than outright rejecting JS only things it's always something that needs to be considered rather than rejected. Every modern browser supports JavaScript, It's on by default and a great number of people leave it on, normally the only people without it are people who manually disabled it cause they don't want it on. So things being considered A) What is your audience, do you really have a large number of people who flat out disable JavaScript? B) The tool, is this really such a absolute necessary feature that you can't require people to turn js on to use it? C) What are the advantages of either side, js or static?
One little JS bonus note over the php page, you can actually make use of page generators in the api to do autocompletion and searching for item names. ie: As the user starts typing query the api for pages within whatever category you put items in that have a certain prefix to the pagetitle, and use that to show a limited autocompletion. ~ NOTASTAFF Dantman(Local Talk ⁝ [[w:c:animanga:User talk:Dantman|Animanga Talk]])02:02, 25 July 2009 (UTC)
I don't see why not allowing the server to generate the content as a fallback is such a bad thing. It's good for search engines because it can actually see something on a page and for people who use embedded devices that don't run JavaScript as fast as a full-sized machine if at all. Ajax applications should have graceful fallback. Its not that difficult for a server script to generate the table. Besides, why would we decide to use JavaScript that requires async API calls over a server-generated page on the wiki itself that can provide the same content without all the network latency and extra overhead involved? Sure, if JavaScript is enabled, add the bells and whistles. You can still have a server-generated page and also have a form that uses JavaScript-based autocomplete, they're not mutually exclusive or anything. I am under the assumption that we can develop our own wiki extensions and have them installed, is that right? If it's too difficult to get them approved on Wikia, then maybe then would we have a good reason to use JavaScript only since it requires less effort by Wikia. --Quarenon  Talk 02:10, 25 July 2009 (UTC)

Installing an extension on Wikia takes awhile. It requires the extension to be tested to make sure it doesn't break Wikia, and work from techs to actually install it before even doing that. In all, unless it's a real important feature that can't be done anywhere else but inside an Extension, it's best to use something JavaScript based. It gives you far more control over the ability to update it as well. It's also important that the person writing the extension is competent at it. Especially when it comes to grabbing data from pages you can write some pretty inefficient extensions in MediaWiki that could slow the wiki down. Not to mention depending on the complexity of the extension it can take awhile to write.

When it comes down to it you'll have two choices on how you're actually going to get that data out of the wiki. A) Manually grabbing page text, and using string manipulation to attempt to extract the information from the pages. B) Integrating the extension with Semantic MediaWiki so that you don't have issues with bad data parsing and the negative parts of A).

The issue with A) is then you become locked into your format, if you ever decide (hey, these templates could use some improvement) and make some changes. You'll have to update the php code for the extension, and go through that long period of getting it rolled out onto Wikia. The issue with B) is that Semantic MediaWiki is a very heavy and complex extension. SMW is such a big extension it's almost like learning MediaWiki twice. Frankly I never bothered looking into how you're supposed to grab the values of properties php side.

In short, if you do it PHP side, you forfeit the ability for the community to make easy changes, and if you try to make it a little easier by integrating into SMW php side, you increase how long it will take to even finish the feature.

As for search engines and whatnot. Why do search engines need to see comparison pages? Those are user requested kind of things, dynamic features for data already being indexed as part of item pages. Search engines don't need to see that.

JavaScript is plenty fast whether you are on an embedded device or not, we're not talking about something like Bespin or GMail here. Just a http request or two, and some jQuery to generate some markup. My iPod Touch could handle that like a brease.

And what about the audience? Are people really browsing rswiki on a low-power mobile device? Runescape is a Java game, the audience by definition needs a decent machine with Java (and it's possible JavaScript might even be enabled for those pages) to play the game.

As for requests. There is little real difference in that regard:

  • PHP Extension: View item article and click link -> Visit special page with one item listed and submit a item name -> Re-visit special page with both items listed
  • JavaScript: View item article and click link -> Request JSON comparison with just the first item -> Request JSON comparison for two items

Technically, you actually save data transfer with the JavaScript option: You don't re-download the contents of the entire skin each time, and when you want to return to the item page you are already on it and just remove the overlay dialog. ~ NOTASTAFF Dantman(Local Talk ⁝ [[w:c:animanga:User talk:Dantman|Animanga Talk]]) 03:15, 25 July 2009 (UTC)

I still dislike the accessibility issues involved with this, but I'll support a JavaScript based solution. It can be done faster than an extension especially considering that Wikia has to take time to evaluate the security and performance implications for every script change, and people will like that they aren't being navigated off the wiki or even the specific page that they were on (as is the case with overlays). --Quarenon  Talk 04:38, 25 July 2009 (UTC)

JavaScript based

I hammered on my keyboard for awhile and came up with this:

http://img9.imageshack.us/img9/7030/captureylukyd.th.png

It's an overlay that appears when you click the "Compare items" link instead of going to another page. This overlay contains the same format as the external tool does now but does not actually load anything that is external to the wiki. Two things that are different right now is the lack of auto-complete, which I'll have working eventually, and this tool actually won't die on articles like Dragonfire shield. I tested it on Google Chrome, Firefox 3.5, and IE 8. --Quarenon  Talk 10:19, 25 July 2009 (UTC)

Also to add, the way this works is that the bonus template doesn't actually use a link anymore. Instead, the table cell where the compare items link should go needs to have a special class. A script contained within [[MediaWiki:Common.js]] executes, finds this class, and populates a link in it. When clicked, the link calls another function from the Common.js file. You can see how the template would be coded in my sandbox. Note that you will see an error message because the script isn't installed on the wiki. --Quarenon  Talk 10:22, 25 July 2009 (UTC)
Looks great so far. =D. - TehKittyCatTalk Wikian-Book 19:31, 25 July 2009 (UTC)
Any way you can let us test it? I'm interested about Mac compatibility. ShinyUnown T | C | E 20:03, 25 July 2009 (UTC)
Btw, JavaScript is not operating system dependent, so I can't think of any reason for it not to work on a Mac. - TehKittyCatTalk Wikian-Book 20:15, 25 July 2009 (UTC)
A few of Quarenon's scripts are not working on my Mac, and they're JavaScript. ShinyUnown T | C | E 20:34, 25 July 2009 (UTC)
Add
importScript('User:Quarenon/compare.js');
to Special:MyPage/monaco.js, then visit my sandbox --Quarenon  Talk 21:50, 25 July 2009 (UTC)
Not working for me, created that page, cleared cache and I still get that not supported message even on IE. Am I doing it wrong? Cap and goggles.pngTEbuddy 21:55, 25 July 2009 (UTC)
Not really, friend, you are doing it right, like I am. Quarey, fix your script! ShinyUnown T | C | E 22:07, 25 July 2009 (UTC)
Tebuddy, are you using the Monobook skin? If you are, put the code in Special:MyPage/monobook.js instead. --Quarenon  Talk 22:10, 25 July 2009 (UTC)
Works for me, I quite like it (even if there's no such item as Quarenon/Sandbox Lol). Takes a second to load the link, before that it shows the 'does not support' message. Quest.png Gaz Lloyd 7:^]Events!99s 22:21, 25 July 2009 (UTC)
Still nothing, page is create at both Special:MyPage/monaco.js and Special:MyPage/monobook.js. I am using the monobook skin, and tried IE, chrome, and opera. Cap and goggles.pngTEbuddy 23:21, 25 July 2009 (UTC)
I can't replicate any problems on any of the browsers you mentioned (assuming they're the most recent version of each) on Monobook. You also put the code correctly in your Special:MyPage/monobook.js, so I'm not sure what's wrong unless you can give some specific error messages from your browser's error console. --Quarenon  Talk 04:11, 26 July 2009 (UTC)
I guess it decided to fix itself and start working in IE, however chrome and opera still show that "item comparison not supported" message. This could be a problem as I currently use chrome as my default browser.Cap and goggles.pngTEbuddy 19:07, 26 July 2009 (UTC)
I'm not really sure why it's not working for you. There may be error messages logged in Chrome's JavaScript console; to open it press Ctrl-Shift-J while on the Sandbox page, and anything that is in red font would be suspect. Other than that, maybe you are running an ad or script blocker? I've also seen instances where Chrome's script engine crashes and doesn't fix itself until you fully restart the browser, but I'm sure you've already tried that by now. --Quarenon  Talk 01:01, 27 July 2009 (UTC)

It's working on my PC laptop. >.> ShinyUnown T | C | E 00:51, 26 July 2009 (UTC) The script works great for me(I'm on a mac to prove that idea wrong) and Firefox 3.6a1pre nightly. Remember you must hard refresh your user js page(follow the instructions at the top of it) for this script to work. - TehKittyCatTalk Wikian-Book 01:35, 26 July 2009 (UTC)

The script works me. Btw, it's very nice, and much better than the previous compare thingy. I use Monobook/Vista/Firefox 3.0.12.
Is the "If you see this" message necessary? Users will be unfamiliar with the term "item compare overlay". Wink   az talk   03:59, 26 July 2009 (UTC)
We can easily change the error message and/or make it smaller. The template code would just be adjusted appropriately. --Quarenon  Talk

Ugh... I think I'll rewrite that script when the smw stuff is setup. It's riddled with bad javascript practices. But guess that's what comes from learning JS from what is on Wikipedia. ~ NOTASTAFF Dantman(Local Talk ⁝ [[w:c:animanga:User talk:Dantman|Animanga Talk]])

After your recent updates to compare.js and css, it's working on my Mac with Safari 3.1. Smile ShinyUnown T | C | E 15:08, 26 July 2009 (UTC)
I'd like to see it indicate the equipment slot though, and at the bottom have a total bonus section (for example, Zanik's crossbow prayer bonus + Holy book prayer bonus = 0 prayer bonus). Of course, we could add an invisible part to Template:Infobox Bonuses to indicate the slot, and I think you could do the rest. Wink ShinyUnown T | C | E 15:16, 26 July 2009 (UTC)
Yeah, the equip slot would be difficult to add unless it gets added as a template parameter somewhere. It can be inferred in some cases right now using categories, but it won't be reliable. A totals row would definitely be useful though. --Quarenon  Talk 01:01, 27 July 2009 (UTC)

Comment - I've added a weight column, which comes from the article's {{Infobox Item}} template if one exists. --Quarenon  Talk 03:19, 29 July 2009 (UTC)

Everything looks nice, that should have comparisons even better. Maybe you could have icons for speed and weight(such as Energy.png for speed, though that might be confusing). Can't wait for it to be added once everything is done. - TehKittyCatTalk Wikian-Book 03:48, 29 July 2009 (UTC)
Is this good? might be good for weight. ShinyUnown T | C | E 11:56, 29 July 2009 (UTC)

Comment - I've added those icons along with search suggest and the ability to set the initial items that appear when the box is opened. See my sandbox for the syntax on how to do that. --Quarenon  Talk 13:52, 29 July 2009 (UTC)

Even with the icons, I would have a text caption so the top row of the table would be: Attack, Defense Speed, Weight(Kg). The new feature might have a lot of uses. - TehKittyCatTalk Wikian-Book 15:10, 29 July 2009 (UTC)
This change has been made. There shouldn't be much confusion now with the text although we can always go for better icons later. --Quarenon  Talk 19:08, 29 July 2009 (UTC)
One thing that bugs me slightly is that the words "Attack" and "Defense" aren't centered vertically. Is there any way to do that? kitty.pngPsycho Robot talkSilver bar.png 21:27, 29 July 2009 (UTC)
That annoyed me as well. I did a few alignment tweaks on that as well as the delete row image and it should be centered now. --Quarenon  Talk 03:41, 30 July 2009 (UTC)
How about a total row, since this may be used for figuring out what to wear and weild. You must have a mile long list of things to do, which keeps on going and growing. - TehKittyCatTalk Wikian-Book 04:23, 30 July 2009 (UTC)
Yep, Killr already suggested it, and it's now finally implemented. eCopM0F.png --Quarenon  Talk 19:45, 31 July 2009 (UTC)
More ideas: Change TOTALS to Total, to make sense (to me), and display the icon for the item (from Template:Infobox Item). Also [[:Image:Smithing detail.png|this]] (but smaller) for weight, and something better for speed. ShinyUnown T | C | E 21:07, 31 July 2009 (UTC)
Comment - Adding the item's image would be nice although it's a little bit complicated to do. I'd prefer skipping on that for now if we're looking to get a working version to deploy for all visitors. --Quarenon  Talk 06:59, 1 August 2009 (UTC)
I've changed the weight icon and made the slight wording change as requested. --Quarenon  Talk 14:51, 7 August 2009 (UTC)

Comment - I have personally used this feature at least a dozen times since it has been implemented; what happened to the overlay though? When I use it as it is it still takes me to personal web space. Cap and goggles.pngTEbuddy 23:25, 31 July 2009 (UTC)

Comment - The overlay hasn't been added site-wide yet. The final wrinkles are being ironed out and it should be ready to go soon. I've made a change so that the new tool works on every item if you've installed the script. The off-site link remains if the compare script hasn't been installed. It would be up to an admin to make some necessary additions to the site-wide script file to make it work for everybody, though. --Quarenon  Talk 04:24, 1 August 2009 (UTC)

Closed - C.ChiamTalk 10:55, September 6, 2009 (UTC)