Forum:Cblair91Bot

From the RuneScape Wiki, the wiki for all things RuneScape
Jump to: navigation, search
Forums: Yew Grove > Cblair91Bot
Archive
This page or section is an archive.
Please do not edit the contents of this page.
This thread was archived on 19 June 2013 by Dtm142.

This is a request for a approval to run and bot flag for User:Cblair91Bot.

A proofbot has been running sporadically of late, and I believe it would be useful to approve a new bot to run the same tasks. Cblair91 has taken A proofbot's source code for Visual editor errors and added various improvements to it based on his experience of visual editor failures on [[w:c:scratchpad|Scratchpad]] and editor errors such as superfluous wikitext and deprecated HTML. The full list of replacements that the bot will apply can be found here. You will notice the bot also removes superfluous span tags, including tags currently blocked by Special:Abusefilter/7 due to difficulty in retrieving the intended edit by hand.

The bot also features a stop system similar to AWB: if it's talk page is edited the bot will stop. Cblair91 is also currently adding a feature that will detect if it's edits are reverted or undone which will also stop the bots process on that current page until reviewed by Cblair91 as to why. He has also pledged to take a sample of the edits made by the bot each day and check them for errors. The bot also complies with {{bots}} and {{nobots}} as all wikipedia bots are expected to on wikipedia. The templates do not currently exist here, but can be used if someone would like to prevent the bot editing the page.

The bot can be seen in action [[w:c:scratchpad:Special:Contributions/Cblair91Bot|here]] (the past months contributions). The source is currently unavailable, but will be released at a later date and released under the same license as A proofbot's source.

Discussion

Support - cqm 12:19, 12 Jun 2013 (UTC) (UTC)

Support as bot owner - Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 12:20, June 12, 2013 (UTC)

Definite Support It's a solid step to a complete aProofbot improvement.King Kolton9 (9 more options)  Choose OptionUser Page King Kolton9 (Level: 9001)Talk to King Kolton9Edit Count King Kolton9Chat at IRCMy Pages My SandboxMy Contributions 17:09, June 12, 2013 (UTC)

Support - Proof may be gone, but her spirit lives on... JOEYTJE50TALKpull my finger 17:56, June 12, 2013 (UTC)

Comment - What spirit haha, the source will probably be all rewritten soon, since most the methods are stupidly coded :( Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 18:00, June 12, 2013 (UTC)
If you just insulted apr I must ask you to please leave forever. Ronan Talk 20:32, June 12, 2013 (UTC)
In the circumstances, this comment suggests nothing so much as that proofbot's code is of high quality. Ardougne cloak 4.png Raging Bull Talk 22:50, June 12, 2013 (UTC)
The insult was not intended towards A proofreader at all, just how some of the methods seem to loop in an annoying way, and could be shortened very much so. Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 23:29, June 12, 2013 (UTC)

Support - Adding in a stop system will be a nice touch in case you make an edit to the source code and things start to go horribly wrong for some reason across the entire wiki; I also like the use of the bot exclusion tags (even though the Visual Editor does not magically stop failing on a page with {{Nobots}} on it).

For now, I assume you're working on the source of A proofbot's VisualEditorFailFixer task itself, and you would have to code your bot exclusion and stop page stuff yourself unless there was already a high-level bot framework for Java in the style of PyWikipediaBot. Do note that I fire off threads in the Java code for queueing multiple edits, and synchronise on the MediaWiki connection for thread safety. If you don't understand the purpose of the synchronized keyword, or why it's placed where it is placed, then I understand why you don't understand the code. In a concurrent access scenario, I also need to handle lots of situations like edit conflicts, as well as back off when the bot's user becomes blocked. I'd like to know why you think the bot is stupidly coded. Perhaps it would help me improve.

Regardless, I like the look of your bot's contributions so far, including the new rules. Just don't add too general ones that catch loads of stuff, and keep a revert back-off algorithm as discussed in the original thread :) If Cblair91Bot gets approved, I'll shut down the VisualEditorFailFixer task on a proofbot and let yours take over, lest your bot not get any testing due to mine getting edits at odd times.

 a proofreader ▸ 

22:59, June 12, 2013 (UTC)

The stop's for if it gets a talk page message and if it detects the nobots template already exist in it, and the detection of undoing it's edit and stopping it from re-applying that edit can be added very quickly. :) Hope that sort of answer's things, as well to why it was "stupidly coded", it would be all the messy functions and the way it handles, when it could be about 3 functions put into one since it's just calling back data un-needingly. Either way, working from your framework was of high use and very welcomed, and I do hope to improve upon it and and notify you that it was of good quality in it's working but slightly messy code (OCD ;( ) Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 23:29, June 12, 2013 (UTC)

No template - I don't see a point in having them. There are no pages where we use styling similar to how the RTE outputs it, and more generally very few that do use any styling (in the page source) at all. Unless Kris's code is so poorly written that it can't avoid <div style="text-align:center"> or <span style="color:red">, we don't need them. MolMan 23:16, June 12, 2013 (UTC)

As stated, the full list of detectors is found here, if it isn't on the list then it won't even attempt to change it ;) Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 09:30, June 13, 2013 (UTC)
I was just noting how much your bot would have to suck for us to need to worry about the templates to prevent a failure. MolMan 19:19, June 13, 2013 (UTC)
I hope that my bot doesn't suck haha... It's just on some pages on the wiki were I test it at, the other admin doesn't want certain pages from being edited (he feels the b tag is still better than ''' (facepalm) Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 21:12, June 13, 2013 (UTC)

Comment - Not every &nbsp; should be replaced with a breaking space. Sometimes it's intentional, usually in dates, but possibly other places as well. --Saftzie (talk) 21:23, June 16, 2013 (UTC)

Weight comes to mind. MolMan 21:25, June 16, 2013 (UTC)
There is &#160; which can be used as an alternative. No RTE error has converted character to numbered html entities, as opposed to named entities like &gt; or &apos;, hence those entities are outside the bot's scope. cqm 22:17, 16 Jun 2013 (UTC) (UTC)
I've noticed a lot of occurrences where RTE has messed up and made it an &nbsp; and messed up a link changing it into a double link like: [[This& page|This page]]... If however you feel special occurrences of tags where it should not be used, please do say :) Custodian crown.svgCblair91User crown.svg (9 more options)  Choose OptionUser Cblair91Talk to Cblair91Contributions Cblair91Achievements Cblair91Sandbox Cblair91Slayer LogSqueel of Fortune LogDaily Challenge LogMy Pages 00:29, June 17, 2013 (UTC)
If it's in a wiki-link, it can go for sure, I think. --Saftzie (talk) 05:39, June 18, 2013 (UTC)

Support - svco4bY.png3Gf5N2F.png 13:43, June 17, 2013 (UTC)

Support - All the problems I took issue with have been fixed. ʞooɔ 15:51, June 18, 2013 (UTC)

Support - Spoke with Cblair about some of the issues the bot had in its earlier stages, and all seem to have been fixed. Suppa chuppa Talk 17:27, June 19, 2013 (UTC)

Closed - Cblair91Bot will be flagged and allowed to operate. Dtm142 (talk) 20:26, June 19, 2013 (UTC)